-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: tox-lsr 3.4.0 - fix py27 tests; move other checks to py310 #13
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -58,7 +58,16 @@ jobs: | |
run: | | ||
set -euxo pipefail | ||
python -m pip install --upgrade pip | ||
pip install "git+https://github.com/linux-system-roles/[email protected]" | ||
if [ "${{ matrix.pyver_os.ver }}" = 2.7 ]; then | ||
# newer virtualenv cannot create python2 venvs | ||
# newer tox requires newer virtualenv | ||
tox='tox<4.15' | ||
virtualenv='virtualenv<20.22.0' | ||
else | ||
tox=tox | ||
virtualenv=virtualenv | ||
fi | ||
pip install "$tox" "$virtualenv" "git+https://github.com/linux-system-roles/[email protected]" | ||
# If you have additional OS dependency packages e.g. libcairo2-dev | ||
# then put them in .github/config/ubuntu-requirements.txt, one | ||
# package per line. | ||
|
@@ -73,11 +82,8 @@ jobs: | |
toxenvs="py${toxpyver}" | ||
# NOTE: The use of flake8, pylint, black with specific | ||
# python envs is arbitrary and must be changed in tox-lsr | ||
# We really should either do those checks using the latest | ||
# version of python, or in every version of python | ||
case "$toxpyver" in | ||
27) toxenvs="${toxenvs},coveralls,flake8,pylint" ;; | ||
36) toxenvs="${toxenvs},coveralls,black" ;; | ||
310) toxenvs="${toxenvs},coveralls,flake8,pylint,black" ;; | ||
*) toxenvs="${toxenvs},coveralls" ;; | ||
esac | ||
TOXENV="$toxenvs" lsr_ci_runtox | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,4 @@ | ||
# SPDX-License-Identifier: MIT | ||
--- | ||
extends: default | ||
ignore: | | ||
/.tox/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check failure
Code scanning / CodeQL
Potentially uninitialized local variable Error test