ci: tox-lsr 3.4.0 - fix py27 tests; move other checks to py310 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest version of virtualenv does not support creating python 2.7 virtualenvs. Change our CI tests to restrict the version of virtualenv<20.22.0 and tox<4.15 for py27 environments Move pylint, flake8, and black checks to the py310 environment which is currently supported by ansible-core 2.17 and its related checkers such as ansible-lint and ansible-test pylint now uses ansible-core 2.17 and restricts the version of pylint to 3.1.0 which is the version used by ansible-test 2.17 Remove `extends: default` for .yamllint.yml. The latest version of ansible-lint will automatically incorporate local yamllint settings unless there is an `extends:`. The above changes require some fixes to the role code. For more information, see linux-system-roles/tox-lsr#168 and linux-system-roles/tox-lsr#170 Signed-off-by: Rich Megginson <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| value = ( | ||
| float(self.factor**self.exponent) / float(ftr**exp) | ||
| ) * self.number | ||
| value = (float(self.factor**self.exponent) / float(ftr**exp)) * self.number |
Check failure
Code scanning / CodeQL
Potentially uninitialized local variable Error test
| value = ( | ||
| float(self.factor**self.exponent) / float(ftr**exp) | ||
| ) * self.number | ||
| value = (float(self.factor**self.exponent) / float(ftr**exp)) * self.number |
Check failure
Code scanning / CodeQL
Potentially uninitialized local variable Error test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of virtualenv does not support creating
python 2.7 virtualenvs. Change our CI tests to restrict the version
of virtualenv<20.22.0 and tox<4.15 for py27 environments
Move pylint, flake8, and black checks to the py310 environment
which is currently supported by ansible-core 2.17 and its related
checkers such as ansible-lint and ansible-test
pylint now uses ansible-core 2.17 and restricts the version of
pylint to 3.1.0 which is the version used by ansible-test 2.17
Remove
extends: defaultfor .yamllint.yml. The latest versionof ansible-lint will automatically incorporate local yamllint
settings unless there is an
extends:.The above changes require some fixes to the role code.
For more information, see
linux-system-roles/tox-lsr#168
and
linux-system-roles/tox-lsr#170
Signed-off-by: Rich Megginson [email protected]