Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lint #320

Merged
merged 5 commits into from
Apr 21, 2023
Merged

Fix lint #320

merged 5 commits into from
Apr 21, 2023

Conversation

zliang-akamai
Copy link
Member

📝 Description

Fix lints, remove deprecated linters

✔️ How to Test

make test

@zliang-akamai zliang-akamai requested a review from a team April 19, 2023 20:20
yec-akamai
yec-akamai reviewed Apr 21, 2023
View reviewed changes
Copy link
Contributor

@yec-akamai yec-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some context on why we're disabling these lints? Some of them seem useful to me, i.e. unused-parameter

@zliang-akamai
Copy link
Member Author

@yec-akamai
It conflicts with our existing code base. This generally requires us to name a unused parameter as an underscore _, which is kind of ugly...

@yec-akamai
Copy link
Contributor

yec-akamai commented Apr 21, 2023 •
edited
Loading

Umm, I think it's very common in industry to name unused ones as an underscore. We probably should refactor our code base instead of disabling it.

yec-akamai
yec-akamai requested changes Apr 21, 2023
View reviewed changes
.golangci.yml Outdated Show resolved Hide resolved
@zliang-akamai zliang-akamai changed the title Zhiwei/fix lint Fix lint Apr 21, 2023
@zliang-akamai zliang-akamai merged commit 92acbec into linode:main Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yec-akamai yec-akamai yec-akamai approved these changes

@lgarber-akamai lgarber-akamai lgarber-akamai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zliang-akamai @yec-akamai @lgarber-akamai