Fix lint (#320)

* Remove deprecated linters

* Fix some lint errors

* Upgrade docker image

* Disable unused-parameter linter

* Fix lint and add unused-parameter rule back

.golangci.yml

@@ -29,6 +29,13 @@ linters-settings:
 linters:
   enable-all: true
   disable:
+    # deprecated linters
+    - deadcode
+    - ifshort
+    - varcheck
+    - nosnakecase
+    ####################
+
     - bodyclose
     - contextcheck
     - nilerr

Makefile

@@ -8,7 +8,7 @@ TEST_TIMEOUT := 5h
 
 SKIP_DOCKER       ?= 0
 GOLANGCILINT      := golangci-lint
-GOLANGCILINT_IMG  := golangci/golangci-lint:v1.46.2-alpine
+GOLANGCILINT_IMG  := golangci/golangci-lint:latest
 GOLANGCILINT_ARGS := run
 
 LINODE_URL := https://api.linode.com/

databases.go

@@ -236,7 +236,7 @@ func (c *Client) ListDatabaseEngines(ctx context.Context, opts *ListOptions) ([]
 }
 
 // GetDatabaseEngine returns a specific Database Engine. This endpoint is cached by default.
-func (c *Client) GetDatabaseEngine(ctx context.Context, opts *ListOptions, engineID string) (*DatabaseEngine, error) {
+func (c *Client) GetDatabaseEngine(ctx context.Context, _ *ListOptions, engineID string) (*DatabaseEngine, error) {
 	e := fmt.Sprintf("databases/engines/%s", engineID)
 
 	if result := c.getCachedResponse(e); result != nil {
@@ -279,7 +279,7 @@ func (c *Client) ListDatabaseTypes(ctx context.Context, opts *ListOptions) ([]Da
 }
 
 // GetDatabaseType returns a specific Database Type. This endpoint is cached by default.
-func (c *Client) GetDatabaseType(ctx context.Context, opts *ListOptions, typeID string) (*DatabaseType, error) {
+func (c *Client) GetDatabaseType(ctx context.Context, _ *ListOptions, typeID string) (*DatabaseType, error) {
 	e := fmt.Sprintf("databases/types/%s", typeID)
 
 	if result := c.getCachedResponse(e); result != nil {

pagination.go

@@ -24,8 +24,8 @@ type PageOptions struct {
 // ListOptions are the pagination and filtering (TODO) parameters for endpoints
 type ListOptions struct {
 	*PageOptions
-	PageSize int
-	Filter   string
+	PageSize int    `json:"page_size"`
+	Filter   string `json:"filter"`
 }
 
 // NewListOptions simplified construction of ListOptions using only

waitfor.go

@@ -270,7 +270,7 @@ func (client Client) WaitForLKEClusterConditions(
 // WaitForEventFinished waits for an entity action to reach the 'finished' state
 // before returning. It will timeout with an error after timeoutSeconds.
 // If the event indicates a failure both the failed event and the error will be returned.
-// nolint
+//nolint
 func (client Client) WaitForEventFinished(ctx context.Context, id any, entityType EntityType, action EventAction, minStart time.Time, timeoutSeconds int) (*Event, error) {
 	titledEntityType := strings.Title(string(entityType))
 	filter := Filter{