Conversation
With #5835 adding `linkerd-await` in most Dockerfiles we require `TARGETARCH` to be set by the system, which is only available in the BuildKit backend. Thus we drop support for plain vanilla docker and remove all references to `DOCKER_BUILDKIT`. The developer docs are being updated accordingly in #5869
jijeesh
pushed a commit
to jijeesh/linkerd2
that referenced
this pull request
Mar 23, 2021
With linkerd#5835 adding `linkerd-await` in most Dockerfiles we require `TARGETARCH` to be set by the system, which is only available in the BuildKit backend. Thus we drop support for plain vanilla docker and remove all references to `DOCKER_BUILDKIT`. The developer docs are being updated accordingly in linkerd#5869 Signed-off-by: Jijeesh <jijeesh.ka@gmail.com>
jijeesh
pushed a commit
to jijeesh/linkerd2
that referenced
this pull request
Apr 21, 2021
With linkerd#5835 adding `linkerd-await` in most Dockerfiles we require `TARGETARCH` to be set by the system, which is only available in the BuildKit backend. Thus we drop support for plain vanilla docker and remove all references to `DOCKER_BUILDKIT`. The developer docs are being updated accordingly in linkerd#5869 Signed-off-by: Jijeesh <jijeesh.ka@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #5835 adding
linkerd-awaitin most Dockerfiles we requireTARGETARCHto be set by the system, which is only available in theBuildKit backend. Thus we drop support for plain vanilla docker and
remove all references to
DOCKER_BUILDKIT. The developer docs are beingupdated accordingly in #5869