docker: Avoid specifying TARGETARCH for await#5835
Merged
kleimkuhler merged 1 commit intomainfrom Feb 26, 2021
Merged
Conversation
When introducing the `linkerd-await` helper, we provided a default value for `TARGETARCH`. This appears to interfere with multi-arch image builds, causing ARM builds to fetch amd64 binaries. Unsetting this default appears to fix this issue.
Member
Author
|
confirmed locally via we're at least fetching the correct binary now.. so I'd expect it to work and confirmed that this is not the behavior on main, where we see: |
Pothulapati
approved these changes
Feb 26, 2021
Contributor
Pothulapati
left a comment
Pothulapati
left a comment
There was a problem hiding this comment.
LGTM, and makes sense as now we seems to use the global TARGETARCH and not overriding it.
kleimkuhler
approved these changes
Feb 26, 2021
Contributor
kleimkuhler
left a comment
kleimkuhler
left a comment
There was a problem hiding this comment.
Thanks this makes sense 👍
alpeb
added a commit
that referenced
this pull request
Mar 8, 2021
With #5835 adding `linkerd-await` in most Dockerfiles we require `TARGETARCH` to be set by the system, which is only available in the BuildKit backend. Thus we drop support for plain vanilla docker and remove all references to `DOCKER_BUILDKIT`. The developer docs are being updated accordingly in #5869
alpeb
added a commit
that referenced
this pull request
Mar 9, 2021
With #5835 adding `linkerd-await` in most Dockerfiles we require `TARGETARCH` to be set by the system, which is only available in the BuildKit backend. Thus we drop support for plain vanilla docker and remove all references to `DOCKER_BUILDKIT`. The developer docs are being updated accordingly in #5869
jijeesh
pushed a commit
to jijeesh/linkerd2
that referenced
this pull request
Mar 23, 2021
When introducing the `linkerd-await` helper, we provided a default value for `TARGETARCH`. This appears to interfere with multi-arch image builds, causing ARM builds to fetch amd64 binaries. Unsetting this default appears to fix this issue. Signed-off-by: Jijeesh <jijeesh.ka@gmail.com>
jijeesh
pushed a commit
to jijeesh/linkerd2
that referenced
this pull request
Mar 23, 2021
With linkerd#5835 adding `linkerd-await` in most Dockerfiles we require `TARGETARCH` to be set by the system, which is only available in the BuildKit backend. Thus we drop support for plain vanilla docker and remove all references to `DOCKER_BUILDKIT`. The developer docs are being updated accordingly in linkerd#5869 Signed-off-by: Jijeesh <jijeesh.ka@gmail.com>
jijeesh
pushed a commit
to jijeesh/linkerd2
that referenced
this pull request
Apr 21, 2021
When introducing the `linkerd-await` helper, we provided a default value for `TARGETARCH`. This appears to interfere with multi-arch image builds, causing ARM builds to fetch amd64 binaries. Unsetting this default appears to fix this issue. Signed-off-by: Jijeesh <jijeesh.ka@gmail.com>
jijeesh
pushed a commit
to jijeesh/linkerd2
that referenced
this pull request
Apr 21, 2021
With linkerd#5835 adding `linkerd-await` in most Dockerfiles we require `TARGETARCH` to be set by the system, which is only available in the BuildKit backend. Thus we drop support for plain vanilla docker and remove all references to `DOCKER_BUILDKIT`. The developer docs are being updated accordingly in linkerd#5869 Signed-off-by: Jijeesh <jijeesh.ka@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When introducing the
linkerd-awaithelper, we provided a default valuefor
TARGETARCH. This appears to interfere with multi-arch imagebuilds, causing ARM builds to fetch amd64 binaries.
Unsetting this default appears to fix this issue.