CI steps for Chocolatey package - take 2#4536
Merged
Conversation
Followup to #4205, supersedes #4205 This adds: - A new job psscript-analyzer into the `statics_checks.yml` workflow for linting the Chocolatey Powershell script. - A new `choco_pack` job in the `release.yml` workflow for updating the Chocolatey spec file and generating the package. This is only triggered for stable releases. It requires a windows runner in order to run the choco tooling (in theory it should have worked on a linux runner but in practice it didn't). - The `Create release` step was updated to upload the generated package, if present. - The source file path in `bin/win/linkerd.nuspec` was updated to make this work.
Member
Author
|
This tested fine in my fork: action run To test you can download that file into Windows, and do
|
adleong
approved these changes
Jun 12, 2020
Contributor
|
@alpeb any reason this hasn't merged yet? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #4205, supersedes #4400
This adds:
statics_checks.ymlworkflow for linting the Chocolatey Powershell script.
choco_packjob in therelease.ymlworkflow forupdating the Chocolatey spec file and generating the
package. This is only triggered for stable releases. It requires
a windows runner in order to run the choco tooling (in theory
it should have worked on a linux runner but in practice it
didn't).
Create releasestep was updated to upload the generated package,if present.
bin/win/linkerd.nuspecwas updatedto make this work.