-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PDB on linkerd-viz Helm chart #11628
Conversation
To avoid disruption during cluster nodes rolling or scaling, it's desired to complement the maxUnavailable from the rolling strategy with a PodDisruptionBudget. This commit adds the respective PDB objects following the core components implementation to the `tap` and `tap-injector` deployments. It can be enabled with the enablePodDisruptionBudget helm chart value. Fixes linkerd#11248 Signed-off-by: Matias Charriere <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
viz/charts/linkerd-viz/values.yaml
Outdated
@@ -50,6 +50,9 @@ tolerations: &default_tolerations | |||
# Enable this only when you have multiple replicas of components. | |||
enablePodAntiAffinity: false | |||
|
|||
# -- enables the creation of pod disruption budgets for tap and tap-injector components |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add web
to the list, and re-run bin/helm-docs
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done. also added metrics-api.
Signed-off-by: Matias Charriere <[email protected]>
90d630f
to
742a730
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This edge release introduces new configuration values in the identity controller for client-go's `QPS` and `Burst` settings. Default values for these settings have also been raised from `5` (QPS) and `10` (Burst) to `100` and `200` respectively. * Added `namespaceSelector` fields for the tap-injector and jaeger-injector webhooks. The webhooks are now configured to skip `kube-system` by default ([#11649]; fixes [#11647]) (thanks @mikutas!) * Added the ability to configure client-go's `QPS` and `Burst` settings in the identity controller ([#11644]) * Improved client-go logging visibility throughout the control plane's components ([#11632]) * Introduced `PodDisruptionBudgets` in the linkerd-viz Helm chart for tap and tap-injector ([#11628]; fixes [#11248]) (thanks @mcharriere!) [#11649]: #11649 [#11647]: #11647 [#11644]: #11644 [#11632]: #11632 [#11628]: #11628 [#11248]: #11248 Signed-off-by: Matei David <[email protected]>
This edge release introduces new configuration values in the identity controller for client-go's `QPS` and `Burst` settings. Default values for these settings have also been raised from `5` (QPS) and `10` (Burst) to `100` and `200` respectively. * Added `namespaceSelector` fields for the tap-injector and jaeger-injector webhooks. The webhooks are now configured to skip `kube-system` by default ([#11649]; fixes [#11647]) (thanks @mikutas!) * Added the ability to configure client-go's `QPS` and `Burst` settings in the identity controller ([#11644]) * Improved client-go logging visibility throughout the control plane's components ([#11632]) * Introduced `PodDisruptionBudgets` in the linkerd-viz Helm chart for tap and tap-injector ([#11628]; fixes [#11248]) (thanks @mcharriere!) [#11649]: #11649 [#11647]: #11647 [#11644]: #11644 [#11632]: #11632 [#11628]: #11628 [#11248]: #11248 Signed-off-by: Matei David <[email protected]>
To avoid disruption during cluster nodes rolling or scaling, it's desired to complement the maxUnavailable from the rolling strategy with a PodDisruptionBudget.
This commit adds the respective PDB objects following the core components implementation to the
tap
,tap-injector
,web
andmetrics-api
deployments. It can be enabled with the enablePodDisruptionBudget helm chart value and are installed only if each of those components have more than 1 replica.Fixes #11248
Previous PR was close due inactivity (#11249), sorry about that.
As requested there, I added in this new PR PDBs for
web
andmetrics-api
.prometheus
has only fixed 1 replica; so it doesn't really make sense to add a PDB for it.