Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PodDisruptionBudgets in linkerd-viz chart #11248

Closed
mcharriere opened this issue Aug 15, 2023 · 2 comments · Fixed by #11628 or #11675
Closed

Add PodDisruptionBudgets in linkerd-viz chart #11248

mcharriere opened this issue Aug 15, 2023 · 2 comments · Fixed by #11628 or #11675

Comments

@mcharriere
Copy link
Contributor

What problem are you trying to solve?

Avoid service disruption when cluster nodes are rolling or scaling.

How should the problem be solved?

Adding a PDB for both tap and tap-injector deployments.

Any alternatives you've considered?

I think PDB is the way to go

How would users interact with this feature?

Add flag to enable/disable pdb on helm chart.

Would you like to work on this feature?

yes

mcharriere added a commit to giantswarm/linkerd2-upstream that referenced this issue Aug 15, 2023
To avoid disruption during cluster nodes rolling or scaling, it's
desired to complement the maxUnavailable from the rolling strategy with
a PodDisruptionBudget.

This commit adds the respective PDB objects following the core
components implementation to the `tap` and `tap-injector` deployments.
It can be enabled with the enablePodDisruptionBudget helm chart value.

Fixes linkerd#11248

Signed-off-by: Matias Charriere <[email protected]>
mcharriere added a commit to giantswarm/linkerd2-upstream that referenced this issue Aug 18, 2023
To avoid disruption during cluster nodes rolling or scaling, it's
desired to complement the maxUnavailable from the rolling strategy with
a PodDisruptionBudget.

This commit adds the respective PDB objects following the core
components implementation to the `tap` and `tap-injector` deployments.
It can be enabled with the enablePodDisruptionBudget helm chart value.

Fixes linkerd#11248

Signed-off-by: Matias Charriere <[email protected]>
mcharriere added a commit to giantswarm/linkerd2-upstream that referenced this issue Aug 18, 2023
To avoid disruption during cluster nodes rolling or scaling, it's
desired to complement the maxUnavailable from the rolling strategy with
a PodDisruptionBudget.

This commit adds the respective PDB objects following the core
components implementation to the `tap` and `tap-injector` deployments.
It can be enabled with the enablePodDisruptionBudget helm chart value.

Fixes linkerd#11248

Signed-off-by: Matias Charriere <[email protected]>
mcharriere added a commit to giantswarm/linkerd2-upstream that referenced this issue Nov 9, 2023
To avoid disruption during cluster nodes rolling or scaling, it's
desired to complement the maxUnavailable from the rolling strategy with
a PodDisruptionBudget.

This commit adds the respective PDB objects following the core
components implementation to the `tap` and `tap-injector` deployments.
It can be enabled with the enablePodDisruptionBudget helm chart value.

Fixes linkerd#11248

Signed-off-by: Matias Charriere <[email protected]>
Copy link

stale bot commented Nov 14, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 14, 2023
mcharriere added a commit to giantswarm/linkerd2-upstream that referenced this issue Nov 17, 2023
To avoid disruption during cluster nodes rolling or scaling, it's
desired to complement the maxUnavailable from the rolling strategy with
a PodDisruptionBudget.

This commit adds the respective PDB objects following the core
components implementation to the `tap` and `tap-injector` deployments.
It can be enabled with the enablePodDisruptionBudget helm chart value.

Fixes linkerd#11248

Signed-off-by: Matias Charriere <[email protected]>
@mcharriere
Copy link
Contributor Author

I created a new PR addressing this issue.

@stale stale bot removed the wontfix label Nov 17, 2023
alpeb pushed a commit that referenced this issue Nov 23, 2023
* Add PDB for tap and tap-injector

To avoid disruption during cluster nodes rolling or scaling, it's
desired to complement the maxUnavailable from the rolling strategy with
a PodDisruptionBudget.

This commit adds the respective PDB objects following the core
components implementation to the `tap` and `tap-injector` deployments.
It can be enabled with the enablePodDisruptionBudget helm chart value.

Fixes #11248

Signed-off-by: Matias Charriere <[email protected]>
mateiidavid added a commit that referenced this issue Nov 30, 2023
This edge release introduces new configuration values in the identity
controller for client-go's `QPS` and `Burst` settings. Default values for these
settings have also been raised from `5` (QPS) and `10` (Burst) to `100` and
`200` respectively.

* Added `namespaceSelector` fields for the tap-injector and jaeger-injector
  webhooks. The webhooks are now configured to skip `kube-system` by default
  ([#11649]; fixes [#11647]) (thanks @mikutas!)
* Added the ability to configure client-go's `QPS` and `Burst` settings in the
  identity controller ([#11644])
* Improved client-go logging visibility throughout the control plane's
  components ([#11632])
* Introduced `PodDisruptionBudgets` in the linkerd-viz Helm chart for tap and
  tap-injector ([#11628]; fixes [#11248]) (thanks @mcharriere!)

[#11649]: #11649
[#11647]: #11647
[#11644]: #11644
[#11632]: #11632
[#11628]: #11628
[#11248]: #11248

Signed-off-by: Matei David <[email protected]>
mateiidavid added a commit that referenced this issue Dec 1, 2023
This edge release introduces new configuration values in the identity
controller for client-go's `QPS` and `Burst` settings. Default values for these
settings have also been raised from `5` (QPS) and `10` (Burst) to `100` and
`200` respectively.

* Added `namespaceSelector` fields for the tap-injector and jaeger-injector
  webhooks. The webhooks are now configured to skip `kube-system` by default
  ([#11649]; fixes [#11647]) (thanks @mikutas!)
* Added the ability to configure client-go's `QPS` and `Burst` settings in the
  identity controller ([#11644])
* Improved client-go logging visibility throughout the control plane's
  components ([#11632])
* Introduced `PodDisruptionBudgets` in the linkerd-viz Helm chart for tap and
  tap-injector ([#11628]; fixes [#11248]) (thanks @mcharriere!)

[#11649]: #11649
[#11647]: #11647
[#11644]: #11644
[#11632]: #11632
[#11628]: #11628
[#11248]: #11248

Signed-off-by: Matei David <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
1 participant