-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Custom Annotations on Linkerd-Viz Prometheus Deployment #11374
Conversation
@alpeb is this good to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cemenson, this looks good to me.
@adleong could I trouble you for a review of this? |
Hi @cemenson, can you tell me more about the use case? What kinds of annotations do you need to add to the Prometheus deployment and why? I'll note that we already have a |
Hi @adleong. For our specific case, we need to set an annotation |
thanks @cemenson, that context is super helpful! How would you feel about renaming the value to |
Thanks, @cemenson. I'm seeing some weird CI failures that I can't reproduce locally. Could you try pulling the latest main and merging it into this branch? Edit: I've merged main, let's see if that resolves the CI issues. |
🎉 🎉 🎉 |
Support for Custom Annotations on Linkerd-Viz Prometheus Deployment
Currently, adding custom annotations to the prometheus deployment isn't supported. This can't be done either with
--set
helm flag or by adding relevant config tovalues.yaml
.By adding additional helm values by way of a
with
keyword within the prometheus deployment yaml, we can support custom annotations. Setting the value of the reverenced value (.Values.prometheusAnnotations
) to empty will ensure this doesn't break or modify any existing deployments.Once merged, setting
prometheusAnnotations
in thevalues.yaml
or via a--set
helm flag will result in specified annotations being included in the prometheus deployment and pod spec.Fixes #11365
I agree to the DCO for all the commits in this PR.