Support for Custom Annotations on Linkerd-Viz Prometheus Deployment #11365
Labels
Comments
|
@cemenson I think that if this approach is a conventional idiom for adding annotations to objects created by a Helm chart, we would accept a PR adding it! |
|
@hawkw I've opened a PR for this - just needs a couple of reviews? |
adleong
added a commit
that referenced
this issue
Oct 3, 2023
…11374) Support for Custom Annotations on Linkerd-Viz Prometheus Deployment Currently, adding custom annotations to the prometheus deployment isn't supported. This can't be done either with `--set` helm flag or by adding relevant config to `values.yaml`. By adding additional helm values by way of a `with` keyword within the prometheus deployment yaml, we can support custom annotations. Setting the value of the reverenced value (`.Values.prometheusAnnotations`) to empty will ensure this doesn't break or modify any existing deployments. Once merged, setting `prometheusAnnotations` in the `values.yaml` or via a `--set` helm flag will result in specified annotations being included in the prometheus deployment and pod spec. Fixes #11365 I agree to the DCO for all the commits in this PR. Co-authored-by: Alex Leong <[email protected]>
Merged
adleong
added a commit
that referenced
this issue
Oct 4, 2023
This edge release adds additional configurability to Linkerd's viz and multicluster extensions. * Added a `podAnnotations` Helm value to allow adding additional annotations to the Linkerd-Viz Prometheus Deployment ([#11365]) (thanks @cemenson) * Added `imagePullSecrets` Helm values to the multicluster chart so that it can be installed in an air-gapped environment. ([#11285]) (thanks @lhaussknecht) [#11365]: #11365 [#11285]: #11285 Signed-off-by: Alex Leong <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
What problem are you trying to solve?
It would be helpful to be able to specify additional custom Kubernetes annotations for the prometheus deployment within the linkerd-viz helm chart.
Currently, there is no direct way to do this (i.e. can't use
--setor avalues.yaml).How should the problem be solved?
Just add a small include on the annotations spec for the prometheus deployment with a default empty object on the
values.yamlthat can be overwritten.Any alternatives you've considered?
Only forking this repo to make the change.
How would users interact with this feature?
By default nothing will change for users, but if they so wish they can specify additional annotations via a
--setorvalues.yamlfile.Would you like to work on this feature?
maybe
The text was updated successfully, but these errors were encountered: