Skip to content

Additional logging for HiveMetadataPreservingTableOperations.java #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shardulm94 merged 3 commits into from
Mar 31, 2021
Merged

Additional logging for HiveMetadataPreservingTableOperations.java #62

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff02bd2
Additional logging for HiveMetadataPreservingTableOperations.java
Mar 29, 2021
e216910
Splitting to seperate function
Mar 30, 2021
fd23b16
Adding descriptive messages before logTable
Mar 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions ...etastore/src/main/java/org/apache/iceberg/hive/HiveMetadataPreservingTableOperations.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import java.util.HashMap;
import java.util.Objects;
import java.util.Optional;
import java.util.stream.Collectors;
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.hive.common.StatsSetupConst;
import org.apache.hadoop.hive.metastore.HiveMetaStoreClient;
Expand All @@ -38,6 +39,8 @@
import org.apache.iceberg.exceptions.NoSuchTableException;
import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap;
import org.apache.thrift.TException;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;


/**
Expand All @@ -52,6 +55,8 @@
* updated.
*/
public class HiveMetadataPreservingTableOperations extends HiveTableOperations {
private static final Logger LOG = LoggerFactory.getLogger(HiveMetadataPreservingTableOperations.class);

private final HiveClientPool metaClients;
private final String database;
private final String tableName;
Expand Down Expand Up @@ -131,6 +136,15 @@ protected void doCommit(TableMetadata base, TableMetadata metadata) {
boolean tableExists = metaClients.run(client -> client.tableExists(database, tableName));
if (tableExists) {
tbl = metaClients.run(client -> client.getTable(database, tableName));
String columns = "";
Copy link

@autumnust autumnust Mar 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could it be wrapped into a helper function (to log column names from table sd) since the code-block seems to be identical ?

Copy link
Author

@nagarathnam200 nagarathnam200 Mar 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

try {
columns = tbl.getSd().getCols().stream().map(column -> column.getName() + " " + column.getType())
.collect(Collectors.joining("\n"));
} catch (Throwable throwable) {
LOG.debug("Encountered {} while fetching columns for {}.{}", throwable.getMessage(),
tbl.getDbName(), tbl.getTableName(), throwable);
}
LOG.debug("Found table: {}.{} with columns: {}", tbl.getDbName(), tbl.getTableName(), columns);
} else {
final long currentTimeMillis = System.currentTimeMillis();
tbl = new Table(tableName,
Expand Down Expand Up @@ -165,6 +179,16 @@ protected void doCommit(TableMetadata base, TableMetadata metadata) {
EnvironmentContext envContext = new EnvironmentContext(
ImmutableMap.of(StatsSetupConst.DO_NOT_UPDATE_STATS, StatsSetupConst.TRUE)
);
String columns = "";
try {
columns = tbl.getSd().getCols().stream().map(column -> column.getName() + " " + column.getType())
.collect(Collectors.joining("\n"));
} catch (Throwable throwable) {
LOG.debug("Encountered {} while fetching columns for {}.{}", throwable.getMessage(),
tbl.getDbName(), tbl.getTableName(), throwable);
}
LOG.debug("Updating the metadata location for: {}.{} containing columns: {} with metadata location: {}",
tbl.getDbName(), tbl.getTableName(), columns, tbl.getParameters().get(METADATA_LOCATION_PROP));
ALTER_TABLE.invoke(client, database, tableName, tbl, envContext);
return null;
});
Expand Down