Additional logging for HiveMetadataPreservingTableOperations.java #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Tested the changes by running TestHiveMetadataPreservingCatalog with debug logging enabled. |
autumnust
reviewed
Mar 30, 2021
| boolean tableExists = metaClients.run(client -> client.tableExists(database, tableName)); | ||
| if (tableExists) { | ||
| tbl = metaClients.run(client -> client.getTable(database, tableName)); | ||
| String columns = ""; |
There was a problem hiding this comment.
Could it be wrapped into a helper function (to log column names from table sd) since the code-block seems to be identical ?
shardulm94
reviewed
Mar 30, 2021
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveMetadataPreservingTableOperations.java
Outdated
Show resolved
Hide resolved
shardulm94
reviewed
Mar 31, 2021
| boolean tableExists = metaClients.run(client -> client.tableExists(database, tableName)); | ||
| if (tableExists) { | ||
| tbl = metaClients.run(client -> client.getTable(database, tableName)); | ||
| logTable(tbl); |
Contributor
There was a problem hiding this comment.
Can we print one more line before each logTable call which provides some context so that the log lines are clearer?
Something along the lines of Fetched table from metastore and Updating table in metastore?
shardulm94
approved these changes
Mar 31, 2021
rzhang10
pushed a commit
to rzhang10/iceberg
that referenced
this pull request
Apr 29, 2021
rzhang10
added a commit
that referenced
this pull request
May 7, 2021
* Hive Metadata Scan: Merge Hive and Avro schemas to fix datatype inconsistencies (#57) Hive Metadata Scan: Fix Hive primitive to Avro logical type conversion (#58) Hive Metadata Scan: Fix support for Hive timestamp type (#61) Co-authored-by: Raymond Zhang <[email protected]> Co-authored-by: Shardul Mahadik <[email protected]> * Hive Catalog: Additional logging for HiveMetadataPreservingTableOperations (#62) * Stop using serdeToFileFormat to unblock formats other than Avro or Orc (#64) * Stop using serdeToFileFormat to unblock formats other than Avro or Orc * Fix style check * Spark: Allow reading timestamp without timezone Cherry-picked PR 48: Spark: Allow reading timestamp without time zone Fix style and refactor read-timestamp-without-zone option to constant after rebase Co-authored-by: Shardul Mahadik <[email protected]> Co-authored-by: nagarathnam200 <[email protected]>
rzhang10
pushed a commit
to rzhang10/iceberg
that referenced
this pull request
May 14, 2021
rzhang10
pushed a commit
that referenced
this pull request
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding additional debug logs to root cause an error where commit to update the metadata location property unintentionally modifies the schema of the table.