Skip to content

Fix and re-enable test_finalize_validated. #4464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
afck merged 2 commits into from
Sep 2, 2025
Merged

Fix and re-enable test_finalize_validated. #4464

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bba927f
Fix and re-enable test_finalize_validated.
afck Sep 2, 2025
67de914
Fix flaky test_sparse_sender_chain.
afck Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions linera-core/src/unit_tests/client_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1271,7 +1271,7 @@ where
B: StorageBuilder,
{
let signer = InMemorySigner::new(None);
let mut builder = TestBuilder::new(storage_builder, 4, 1, signer).await?;
let mut builder = TestBuilder::new(storage_builder, 2, 0, signer).await?;
let sender = builder.add_root_chain(1, Amount::from_tokens(4)).await?;
let receiver = builder.add_root_chain(2, Amount::ZERO).await?;
let receiver_id = receiver.chain_id();
Expand Down Expand Up @@ -2115,9 +2115,6 @@ where
Ok(())
}

// TODO(#3860): this test is currently intermittently failing if the faulty validators respond to
// client0 before the correct ones. Un-ignore when this issue is fixed.
#[ignore]
#[test_case(MemoryStorageBuilder::default(); "memory")]
#[cfg_attr(feature = "storage-service", test_case(ServiceStorageBuilder::new().await; "storage_service"))]
#[cfg_attr(feature = "rocksdb", test_case(RocksDbStorageBuilder::new().await; "rocks_db"))]
Expand Down Expand Up @@ -2158,6 +2155,10 @@ where
.burn(AccountOwner::CHAIN, Amount::from_tokens(3))
.await;
assert!(result.is_err());
// Make sure at least one validator has added the proposal to its state.
let info = client0.chain_info_with_manager_values().await?;
let proposal = info.manager.requested_proposed.unwrap();
builder.node(1).handle_block_proposal(*proposal).await?;

// Client 1 thinks it is madness to burn 3 tokens! They want to publish a blob instead.
// The validators are still faulty: They validate blocks but don't confirm them.
Expand All @@ -2179,8 +2180,8 @@ where
.blobs
.is_empty());

// Finally, the validators are online and honest again.
builder.set_fault_type([1, 2], FaultType::Honest);
// Finally, enough validators are online and honest again.
builder.set_fault_type([2], FaultType::Honest);
client0.synchronize_from_validators().await.unwrap();
let manager = client0
.chain_info_with_manager_values()
Expand Down
Loading