Fix and re-enable test_finalize_validated.#4464
Merged
afck merged 2 commits intolinera-io:mainfrom Sep 2, 2025
Merged
Conversation
Contributor
|
Just as a note for the future: |
afck
added a commit
to afck/linera-protocol
that referenced
this pull request
Sep 4, 2025
## Motivation This test is `#[ignore]`d because it's flaky: If the faulty validators respond before the other ones start processing the proposal, neither of them will have the proposal in their chain manager. Also, `test_sparse_sender_chain` is flaky: If the randomly chosen validator (the first in the committee, i.e. by public key) is faulty, processing the notification will fail. ## Proposal Explicitly handle the proposal in one of the validators to make sure the test is set up for the intended scenario. In `test_sparse_sender_chain`, use two validators with no faulty one, so the selected validator is guaranteed to have the block. ## Test Plan I ran it 20 times locally and it always passed. ## Release Plan - Nothing to do / These changes follow the usual release cycle. - (Backporting would be no problem.) ## Links - Closes linera-io#3860. - [reviewer checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist)
Closed
ma2bd
pushed a commit
that referenced
this pull request
Sep 5, 2025
## Motivation This test is `#[ignore]`d because it's flaky: If the faulty validators respond before the other ones start processing the proposal, neither of them will have the proposal in their chain manager. Also, `test_sparse_sender_chain` is flaky: If the randomly chosen validator (the first in the committee, i.e. by public key) is faulty, processing the notification will fail. ## Proposal Explicitly handle the proposal in one of the validators to make sure the test is set up for the intended scenario. In `test_sparse_sender_chain`, use two validators with no faulty one, so the selected validator is guaranteed to have the block. ## Test Plan I ran it 20 times locally and it always passed. ## Release Plan - Nothing to do / These changes follow the usual release cycle. - (Backporting would be no problem.) ## Links - Closes #3860. - [reviewer checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist)
ma2bd
pushed a commit
that referenced
this pull request
Sep 5, 2025
## Motivation This test is `#[ignore]`d because it's flaky: If the faulty validators respond before the other ones start processing the proposal, neither of them will have the proposal in their chain manager. Also, `test_sparse_sender_chain` is flaky: If the randomly chosen validator (the first in the committee, i.e. by public key) is faulty, processing the notification will fail. ## Proposal Explicitly handle the proposal in one of the validators to make sure the test is set up for the intended scenario. In `test_sparse_sender_chain`, use two validators with no faulty one, so the selected validator is guaranteed to have the block. ## Test Plan I ran it 20 times locally and it always passed. ## Release Plan - Nothing to do / These changes follow the usual release cycle. - (Backporting would be no problem.) ## Links - Closes #3860. - [reviewer checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This test is
#[ignore]d because it's flaky: If the faulty validators respond before the other ones start processing the proposal, neither of them will have the proposal in their chain manager.Also,
test_sparse_sender_chainis flaky: If the randomly chosen validator (the first in the committee, i.e. by public key) is faulty, processing the notification will fail.Proposal
Explicitly handle the proposal in one of the validators to make sure the test is set up for the intended scenario.
In
test_sparse_sender_chain, use two validators with no faulty one, so the selected validator is guaranteed to have the block.Test Plan
I ran it 20 times locally and it always passed.
Release Plan
Links
test_finalize_validated#3860.