Move the create-and-call test case from end-to-end to integration test.#4394
Merged
MathieuDutSik merged 3 commits intolinera-io:mainfrom Aug 22, 2025
Merged
Conversation
ma2bd
approved these changes
Aug 22, 2025
Contributor
Author
I looked at this problem of moving the tests to What I propose is instead to create a |
ma2bd
pushed a commit
that referenced
this pull request
Sep 27, 2025
… 4394) (#4671) Backport of #4394 ## Motivation Remove the test `create-and-call` that creates spammy output. ## Proposal Simply remove the `test_create_and_call_end_to_end` from the `linera-service` tests. The integration test has not been added. ## Test Plan CI. ## Release Plan The change should go into `testnet_conway`. It affects only the CI. ## Links None.
MathieuDutSik
added a commit
that referenced
this pull request
Oct 7, 2025
… changes. (#4739) Backports #4406, #4397, #4394, #4366 ## Motivation Several changes to the CI are welcomed and make working easier. Fewer end-to-end tests for what is not viewed as essential. ## Proposal Those 4 PRs are backported to TestNet Conway. ## Test Plan The tests are tested in the same way as in the main. ## Release Plan Backports to TestNet Conway. ## Links None.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The end-to-end tests are relatively expensive in CI. So, it is advantageous to move them to integration tests.
Proposal
We do the following:
&selfofActiveChainthat is not needed.ActiveChainpublic to be used in the operational test.Bytecodesince to instantiate, we cannot use the compressed bytecode.create-and-callsmart contract.Test Plan
The CI.
The PR that introduces the
create-and-callalso addresses the persistence of the contract and service blobsthat have been created. We tested that this integration test fails if the correction is removed.
Release Plan
Links
None.