Address a bug with message during instantiation.#4366
Address a bug with message during instantiation.#4366MathieuDutSik merged 1 commit intolinera-io:mainfrom
Conversation
MathieuDutSik
force-pushed
the
msg_instantiation
branch
from
28904a2 to
813c9f4
Compare
|
|
||
| let block = creation_certificate.inner().block(); | ||
| assert_eq!(block.messages().len(), 1); | ||
| assert!(block.messages()[0].is_empty()); |
There was a problem hiding this comment.
Do we need the other assert?
There was a problem hiding this comment.
Yes it is the fix.
Yes, we need the other assert. When we instantiate, we have only one block of messages being emitted.
afck
left a comment
afck
left a comment
There was a problem hiding this comment.
Good catch! I agree with the fix. But do we really need a slow and expensive end-to-end regression test for that one removed line?
No, we do not need it. |
So, I removed the end-to-end test. But I kept the integration test. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
MathieuDutSik
force-pushed
the
msg_instantiation
branch
from
8d619b2 to
80604f5
Compare
…chain will process the message correctly.
MathieuDutSik
force-pushed
the
msg_instantiation
branch
from
80604f5 to
cd63552
Compare
… changes. (#4739) Backports #4406, #4397, #4394, #4366 ## Motivation Several changes to the CI are welcomed and make working easier. Fewer end-to-end tests for what is not viewed as essential. ## Proposal Those 4 PRs are backported to TestNet Conway. ## Test Plan The tests are tested in the same way as in the main. ## Release Plan Backports to TestNet Conway. ## Links None.
3 participants
Motivation
The scenario of a smart contract emitting a message during instantiation breaks the
TestValidatorframework.We address the problem here.
Fixes #3539
Proposal
The correction pointed out in the issue is exactly what is needed.
A smart contract has been created that demonstrates that the correction works and also test
in the end-to-end test, which is nice to check.
Test Plan
CI.
Release Plan
Links
None.