Conversation
deuszx
force-pushed
the
charge-blob-publish-when-it-happens
branch
2 times, most recently
from
8d5a306 to
8308dea
Compare
deuszx
force-pushed
the
charge-blob-publish-when-it-happens
branch
from
8308dea to
dea2047
Compare
deuszx
force-pushed
the
charge-blob-publish-when-it-happens
branch
from
dea2047 to
19ed9e9
Compare
ma2bd
reviewed
May 23, 2025
afck
reviewed
May 23, 2025
deuszx
force-pushed
the
charge-blob-publish-when-it-happens
branch
from
c9563c9 to
1fdebe0
Compare
afck
reviewed
May 23, 2025
linera-base/src/data_types.rs
Outdated
| } | ||
|
|
||
| /// Returns whether the blob is a "user blob". | ||
| pub fn is_user_blob(&self) -> bool { |
Contributor
There was a problem hiding this comment.
Maybe we should do the opposite, is_committee_blob? That's more specific… and I don't like using quotes in comments—that sounds like it's not the correct technical term.
Contributor
Author
There was a problem hiding this comment.
afck
approved these changes
May 23, 2025
deuszx
force-pushed
the
charge-blob-publish-when-it-happens
branch
from
671e4d1 to
6e43053
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We are charging for all published blobs before we execute any operation in the block. This is wrong b/c we want the incoming grant to be able to cover the fees. The grants are processed during operation processing only so they are not taken into account at the beginning of the block processing.
Proposal
Move the published blobs' resources tracking to the end of processing a transaction that published it. At this point any incoming grant is already processed. In order to do so, we track blob IDs referenced during transaction execution via
TransactionTracker.published_blobsand consume it inBlockExecutionTracker::process_txn_outcome.Also, charge for publishing user-created blobs only.
BlobType::Committeeis not accounted for.Test Plan
CI.
Release Plan
Links