Move blob fee tracking into execute_operation.#3605
Closed
afck wants to merge 1 commit intolinera-io:mainfrom
Closed
Move blob fee tracking into execute_operation.#3605afck wants to merge 1 commit intolinera-io:mainfrom
afck wants to merge 1 commit intolinera-io:mainfrom
Conversation
3 tasks
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Ideally fees should be tracked as closely as possible in the code to where the operation that caused them is processed. Currently we are tracking fees for publishing blobs all at once at the start of
execute_block.(See discussion here: #3546 (review))
Proposal
Move that logic into
execute_operation.Test Plan
Only refactoring.
Release Plan
Links