Skip to content

Simplification storage initialization of the dual-store database backend#3870

Merged
ndr-ds merged 3 commits intolinera-io:mainfrom
ma2bd:storage_init_simplification
May 1, 2025
Merged

Simplification storage initialization of the dual-store database backend#3870
ndr-ds merged 3 commits intolinera-io:mainfrom
ma2bd:storage_init_simplification

Conversation

@ma2bd
Copy link
Contributor

@ma2bd ma2bd commented May 1, 2025 •
edited
Loading

Motivation

After #3787, it is no longer needed to initialize the shard of the dual-store databases separately.

Proposal

Remove special code added in #2734

Test Plan

CI

@ma2bd ma2bd changed the title Simplification storage initialiation of DualStore Simplification storage initialization of DualStore May 1, 2025
@ma2bd ma2bd changed the title Simplification storage initialization of DualStore Simplification storage initialization of the dual-store database backend May 1, 2025
@ma2bd ma2bd requested review from MathieuDutSik, Twey and ndr-ds May 1, 2025 18:27
@ma2bd ma2bd marked this pull request as draft May 1, 2025 18:45
@ma2bd ma2bd force-pushed the storage_init_simplification branch from dc9dbe7 to 06bd8e6 Compare May 1, 2025 19:08
@ma2bd ma2bd marked this pull request as ready for review May 1, 2025 19:09
@ma2bd ma2bd force-pushed the storage_init_simplification branch from 06bd8e6 to 58005be Compare May 1, 2025 19:17
ndr-ds
ndr-ds approved these changes May 1, 2025
View reviewed changes
Copy link
Contributor

@ndr-ds ndr-ds left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
shipit

@ndr-ds Graphite App
Copy link
Contributor

ndr-ds commented May 1, 2025 •
edited
Loading

Merge activity

  • May 1, 3:45 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • May 1, 3:45 PM EDT: Graphite couldn't merge this PR because it failed for an unknown reason (Stack merges are not currently supported for forked repositories. Please create a branch in the target repository in order to merge).

@ndr-ds ndr-ds merged commit 9a629aa into linera-io:main May 1, 2025
24 checks passed
ma2bd added a commit to ma2bd/linera-protocol that referenced this pull request May 1, 2025
@ma2bd
fix dual store after linera-io#3870
0ac4c1a
@ma2bd ma2bd mentioned this pull request May 1, 2025
Merged
ndr-ds pushed a commit that referenced this pull request May 1, 2025
@ma2bd
Fix CI after #3870 (#3872)
d91699f 
## Motivation

#3870 was incomplete and CI didn't catch it

## Proposal

Bring back the logic to diversify local rocksdb directories when testing

## Test Plan

CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndr-ds ndr-ds ndr-ds approved these changes

@Twey Twey Awaiting requested review from Twey

@MathieuDutSik MathieuDutSik Awaiting requested review from MathieuDutSik

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ma2bd @ndr-ds