-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce dual-store
support
#2734
Open
MathieuDutSik
wants to merge
9
commits into
linera-io:main
Choose a base branch
from
MathieuDutSik:dual_store_support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@MathieuDutSik Since the |
Wow, this is surprising. Do we have an explanation? |
for memory and rocksdb.
MathieuDutSik
force-pushed
the
dual_store_support
branch
from
December 16, 2024 08:10
fc85d73
to
7e05956
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
dual.rs
provides support for the dual stores. However, it was not implemented. This PR addresses that.Proposal
The following was done:
fn create
should creates an error if the namespace already exists. This was added to theadmin_test
admin tests.linera-storage-service
,dual
,memory
androcksdb
backends.DualStore
was introduced to thelinera-client/src/storage.rs
.DEFAULT_ROOT_KEY
andDEFAULT_NAMESPACE
are introduced in thelinera-storage
and used.Test Plan
(A) The CI should provide the consistency check.
(B) The usage of the dualstore in the tests adds more work to the CI, so it was limited to the counter and amm tests.
(C) The runtime is not optimistic. For 19 tests the runtime is 1415 seconds with dualstoreRocksDb_Scylla and 928 seconds for running with the ScyllaDb. Therefore, the dual store is not recommended to be used. But its insertion is I think valuable to the source code.
Release Plan
The implementation of the system into TestNet / DevNet is quite premature. So, right now, it is
Links