Conversation
This was referenced Feb 28, 2025
Contributor
Author
|
Just pasting here from our offline discussion: This affects just the initial deployment, it doesn't affect rolling updates. That's controlled by a different setting, which has rolling updates as the default https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/#update-strategies |
ndr-ds
changed the base branch from
02-28-add_option_to_leak_chains_on_benchmark
to
graphite-base/3448
ndr-ds
force-pushed
the
02-28-start_shards_in_parallel
branch
from
2c2d470 to
3fd187d
Compare
ndr-ds
force-pushed
the
graphite-base/3448
branch
from
e3d282b to
da4d752
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Right now we start all shards one by one. That doesn't seem necessary, and when starting a large number of shards (like 100 or more), it can take a long time.
Proposal
Change the pod management policy to start all shards at once, in parallel
Test Plan
Deployed a local kind network with 80 shards, saw all of them getting initialized in parallel, much faster
Release Plan