Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ndr-ds
force-pushed
the
02-25-add_--policy-config_argument_to_create-genesis-config
branch
from
6843226 to
5374f62
Compare
ndr-ds
force-pushed
the
02-26-pretty_print_bps_tps_numbers
branch
from
0dbd832 to
f54e9c8
Compare
ndr-ds
changed the base branch from
02-25-add_--policy-config_argument_to_create-genesis-config
to
graphite-base/3434
ndr-ds
force-pushed
the
graphite-base/3434
branch
from
5374f62 to
da4d752
Compare
ndr-ds
force-pushed
the
02-26-pretty_print_bps_tps_numbers
branch
from
f54e9c8 to
ea144ff
Compare
ndr-ds
force-pushed
the
02-26-pretty_print_bps_tps_numbers
branch
from
ea144ff to
e9e5ed3
Compare
ma2bd
approved these changes
Mar 1, 2025
afck
approved these changes
Mar 2, 2025
ndr-ds
force-pushed
the
02-26-pretty_print_bps_tps_numbers
branch
from
e9e5ed3 to
b3bfdc0
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Right now, specially for higher TPS values, it's harder to read the number
Proposal
Pretty print it so it shows the thousands separators, etc
Test Plan
Ran it, saw the prints being more readable
Release Plan