Conversation
|
Could you go into more detail what you mean by disturbing? Was there a technical difficulty or is this a description of your state of mind? |
|
It is confusing when importing what vello to use |
This isn't a compelling reason, imo. The onus is on you to understand which version of vello you can use with vello_svg. In fact, vello is re-exported to help alleviate that confusion. For example, if your use case is only to render an SVG, you would only need I would however be open to a "vello compatibility chart" on the README, like many crates do with bevy. We currently have a badge in the README, but I don't see that being future proof. |
That is valuable feedback and we can act on it. Given that the re-export itself is valid, our approach should be something other than removing it. Improving our documentation would be a good step. In This crate also re-exports [`usvg`], to make handling dependency versions easierWe could update it to something like: We re-export [`vello`] and [`usvg`] for your convenience,
so you can easily use the specific versions that are compatible with Vello SVG. |
|
If I was to weigh in my 2cents, perhaps the best design pattern would be a cargo feature, like we've done with We could re-export |
|
I'm going to close this as won't do, because the lib.rs documentation has been updated in #18 to reflect why we re-export these libraries to users, using Kaur's verbage. |
I removed the pub use vello; reexport from vello_svg as I found it disturbing when using it on a project that already used vello and ships vello_svg as an addition behind a feature flag, as well as velato, which also reexports vello currently.