Conversation
Member
Author
Closed
This was referenced Jul 3, 2024
Closed
DJMcNab
approved these changes
Jul 3, 2024
Member
DJMcNab
left a comment
There was a problem hiding this comment.
Following optimistic approval policy for Vello SVG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.3.0
Added
vello_svg::Error, which is returned by new functions that read text into ausvg::Tree.vello_svg::render, which takes an svg string and renders to a new vello scene.vello_svg::append, which takes an svg string and renders to a provided vello scene.vello_svg::append_with, which takes an svg string and renders to a provided vello scene with and error handler.vello_svg::render_tree, which takes a usvg::Tree and renders to a provided vello scene with and error handler.Changed
render_treetoappend_treerender_tree_withtoappend_tree_withand removed theResult<(), E>return type for the error handler.