Refactor LFS file handling in CI slightly #833
Merged
+12
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures: 1) The hashing differences on windows and linux don't impact us - https://xi.zulipchat.com/#narrow/channel/419691-linebender/topic/Parley.20CI.20failing.20.28due.20to.20LFS.20failure.3F.29/near/500383610 2) Only explicitly asked for LFS files are downloaded (avoiding accidental successes if these get out of sync) 3) There's a single source of truth for which files are impacted
This is a bit awkward
DJMcNab
commented
Mar 5, 2025
| @@ -15,6 +15,8 @@ env: | |||
| # List of packages that can not target Wasm. | |||
| # `vello_tests` uses `nv-flip`, which doesn't support Wasm. | |||
| NO_WASM_PKGS: "--exclude vello_tests --exclude simple_sdl2" | |||
| # The files stored in LFS the tests need to access | |||
| LFS_FILES: "vello_tests/snapshots/*.png" | |||
There was a problem hiding this comment.
I'm not sure how well this will handle adding additional files.
I think the approach is to add a comma within the quotes, which I think might work in both places. But it's a bit unclear
There was a problem hiding this comment.
We can cross that bridge when we actually need to. It's just a question of style - there are multiple possible solutions. 👍
There was a problem hiding this comment.
The issue is isomorphic to https://github.com/orgs/community/discussions/25761#discussioncomment-6508758, I believe
There was a problem hiding this comment.
Aha, that soon. I can look at it later today and/or tomorrow if you guys haven't solved it before then.
xStrom
approved these changes
Mar 5, 2025
DJMcNab
added a commit
to DJMcNab/xilem
that referenced
this pull request
Mar 5, 2025
DJMcNab
added a commit
to DJMcNab/parley
that referenced
this pull request
Mar 5, 2025
github-merge-queue bot
pushed a commit
to linebender/xilem
that referenced
this pull request
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures: