Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests for vello_cpu #832

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add integration tests for vello_cpu #832

wants to merge 1 commit into from

Conversation

LaurenzV
Copy link
Contributor

@LaurenzV LaurenzV commented Mar 5, 2025

Based on #830, which should be merged first.

I tried to follow the steps for Git LFS, but I'm not sure whether it actually worked.

@LaurenzV LaurenzV requested a review from DJMcNab March 5, 2025 09:50
@LaurenzV LaurenzV marked this pull request as draft March 5, 2025 10:10
@DJMcNab
Copy link
Member

DJMcNab commented Mar 5, 2025

I think you'll probably need linebender/xilem@d4dca3e, although for slightly different reasons

@LaurenzV
Copy link
Contributor Author

LaurenzV commented Mar 5, 2025

I mean, the other temporary option is to just store all screenshots in the same folder for now. Though I'm not sure how great it is to mix sparse_strip stuff with other vello stuff.

@xStrom
Copy link
Member

xStrom commented Mar 5, 2025

Having a single vello_tests/lfs directory that contains all the LFS stuff does indeed seem like the simplest solution so we can just move on.

# Having all the LFS stuff with a single root path:
vello_tests/lfs
vello_tests/lfs/snapshots
vello_tests/lfs/refs

# Would mean we can just use:
vello_tests/lfs/**/*.png

I would go with that.

@LaurenzV
Copy link
Contributor Author

LaurenzV commented Mar 5, 2025

Okay, I will try to do that tomorrow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants