Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Data for chrono types #1743

Merged
merged 2 commits into from
Apr 29, 2021
Merged

Implement Data for chrono types #1743

merged 2 commits into from
Apr 29, 2021

Conversation

r-ml
Copy link
Contributor

@r-ml r-ml commented Apr 27, 2021

Closes #1736

@r-ml r-ml force-pushed the chrono-data-impl branch from 7c377e0 to 4bdd993 Compare April 27, 2021 14:11
@r-ml
Copy link
Contributor Author

r-ml commented Apr 27, 2021

Question: Do we re-export like with the im crate?

@SecondFlight SecondFlight added the S-needs-review waits for review label Apr 27, 2021
cmyr
cmyr approved these changes Apr 28, 2021
View reviewed changes
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think there are a few things missing from the changelog, but otherwise this looks good.

CHANGELOG.md Show resolved Hide resolved
@r-ml r-ml force-pushed the chrono-data-impl branch from 4bdd993 to 0f41105 Compare April 28, 2021 18:21
@SecondFlight SecondFlight added S-ready PR is ready to merge and removed S-needs-review waits for review labels Apr 28, 2021
@SecondFlight SecondFlight merged commit 8717d0c into linebender:master Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmyr cmyr cmyr approved these changes

Assignees
No one assigned
Labels
S-ready PR is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for Chrono behind feature flag
3 participants
@r-ml @cmyr @SecondFlight