Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Chrono behind feature flag #1736

Closed
arthmis opened this issue Apr 24, 2021 · 2 comments · Fixed by #1743
Closed

Support for Chrono behind feature flag #1736

arthmis opened this issue Apr 24, 2021 · 2 comments · Fixed by #1743

Comments

@arthmis
Copy link
Collaborator

arthmis commented Apr 24, 2021

It would nice to have Data implemented for Chrono data types behind a feature flag. It's not very essential I think though.

r-ml added a commit to r-ml/druid that referenced this issue Apr 27, 2021
r-ml added a commit to r-ml/druid that referenced this issue Apr 27, 2021
@cmyr
Copy link
Member

cmyr commented Apr 28, 2021

This is a tricky question. In theory there are an unlimited number of external types, and it's hard to determine what should qualify for inclusion for the purposes of Data. One concern is that this increases the cost of testing, since we want to test all features.

chrono feels like a reasonable thing to include, since it's so commonly used, and time is an important concept in a GUI. Especially since we will likely eventually ship a date picker, I think this makes sense.

@arthmis
Copy link
Collaborator Author

arthmis commented Apr 28, 2021

Yes for my case, it alleviates needing to implement Data manually for types that contain chrono types. It's not a problem, but just a bit annoying.

r-ml added a commit to r-ml/druid that referenced this issue Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants