Fix recursively calling of menuDidChange: #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the issue #46 is relative to this. |
|
👍 I just built your branch and it's working great! |
limejelly
pushed a commit
that referenced
this pull request
Jun 9, 2015
Fix recursively calling of menuDidChange:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a workaround. It may be removed in the final release of OS X 10.11 and Xcode 7.
In 10.11 DP, the NSMenuDidChangeItemNotification fires whenever a new menu item is "adding",
of course including the item we're trying to add now.
I agree it's a bug because "DidChange" should be notified AFTER the changes.
Similar bug is reported in Xcode plug-in "FuzzyAutoComplete"'s issue, which is considered as
a bug introduced by 10.10.2-dp(which is fixed in 10.10.2 final release):