Fix an infinite loop in OS X 10.10.2 (14C94b)

[luosheng]

It seems adding a menu item will fire the NSMenuDidChangeItemNotification in 10.10.2 (14C94b), which will result in an infinite loop. Remove the observer before adding the item should be good to fix this.

[jxdwinter]

+1

[slazyk]

This does not seem to be a correct fix.

We observe this notification because Editor menu changes (for example when you switch from an .m file to a .xib file). If you just remove the observer, then the menu item will be missing after subsequent changes.

It is weird that it recurs, there is a check not to add the item if it is already there. And since it is DidChange the item should already be there. You could try looking into this for a correct fix.

And for a more correct workaround you can either:

• introduce a boolean guard flag (something like isHandlingMenuChange) and use it to prevent recurrence
• inspect the notification and decide wether to try to add the menu item based on it
• remove and re-add observer as needed (best to do it in the menuDidChange: notification handler though).

[luosheng]

Thanks for the explanation. I've re-added the observer after FuzzyAutocomplete menu item is added to the Editor menu. Please kindly check it out.