Repository navigation
[Store] Backport HA RPC recovery fixes - #59
Merged
Merged
Conversation
Yong-ee
force-pushed
the
hy/ha-rpc-staged
branch
2 times, most recently
from
October 16, 2026 12:21
9aef12f to
5f81b85
Compare
Yong-ee
force-pushed
the
hy/ha-rpc-staged
branch
from
October 16, 2026 12:52
5f81b85 to
8164de5
Compare
4 of 28 tasks
5 of 16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport HA RPC recovery fixes needed by the
v0.3.13.post1_l4deployment branch.This change is based on upstream PRs kvcache-ai#3743 and kvcache-ai#3943, adapted without importing unrelated OpLog, snapshot, or DFS changes.
The changes:
MC_RPC_TIMEOUT_MSis explicitly set; connection and retry overrides remain available through the existing environment variables.References: kvcache-ai#3743, kvcache-ai#3943.
Module
mooncake-store)mooncake-common)mooncake-transfer-engine)Type of Change
How Has This Been Tested?
Checks completed:
The Etcd wrapper Go tests passed (
[no test files]). The RPC timeout test expectations cover the bounded HA/non-HA connection policy and the 30-second default request timeout. A usable CMake build directory was not available in the development environment, so C++ compilation and integration tests were not run locally.Checklist
./scripts/code_format.shAI Assistance Disclosure
The changes were prepared with AI assistance. The human submitter is responsible for reviewing every changed line and defending the implementation end-to-end.