Skip to content

[Bugfix] Remove obsolete RPC pool recreation - #102

Merged
lihenga merged 1 commit into
v0.3.13.post1_l4from
remove-recreate-client-pool
Oct 21, 2026
Merged

lihenga merged 1 commit into
v0.3.13.post1_l4from
remove-recreate-client-pool

Conversation

@Yong-ee

@Yong-ee Yong-ee commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Description

移除已不再需要的 RecreateClientPool 及 force_recreate 参数,统一通过共享注册表复用 RPC client pool。

PR #59 最初为非 HA 心跳重连引入强制重建池逻辑;PR #80 已将心跳重连改为复用现有池。继续保留该接口会绕过共享池注册表,并通过永久保活容器积累退役池。当前所有连接路径均可由 GetOrCreateClientPool 处理,因此删除这条遗留路径。

Module

  • Mooncake Store (mooncake-store)
  • Common (mooncake-common)

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Breaking change
  • Documentation update
  • Performance improvement

How Has This Been Tested?

Test commands:

git diff --check
rg -n "RecreateClientPool|KeepMasterPoolAlive|force_recreate" .

Test results:

  • git diff --check passed.
  • Confirmed no remaining references to the removed APIs.
  • C++ build/tests were not run because no usable CMake build directory was available.
  • pre-commit was not run because it is not installed in the environment.

Checklist

  • I have performed a self-review of my own code
  • I have formatted my code using ./scripts/code_format.sh
  • I have run pre-commit on the files changed in this PR and all hooks pass
  • I have updated the documentation (not applicable)
  • I have added tests to prove my changes are effective
  • For changes >500 LOC: I have filed an RFC issue (not applicable)

AI Assistance Disclosure

  • No AI tools were used
  • AI tools were used.

The changes were prepared with AI assistance. The human submitter is responsible for reviewing every changed line and defending the implementation end-to-end.

@lihenga
lihenga merged commit e137a69 into v0.3.13.post1_l4 Oct 21, 2026
2 of 5 checks passed
lihenga added a commit that referenced this pull request Oct 22, 2026
[Bugfix] Remove obsolete RPC pool recreation

(cherry picked from commit e137a69)
@lihenga
lihenga deleted the remove-recreate-client-pool branch November 4, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants