route blinding [4/4]: update MC on receive from blinded path#9004
Open
ellemouton wants to merge 12 commits intolightningnetwork:masterfrom
Open
route blinding [4/4]: update MC on receive from blinded path#9004ellemouton wants to merge 12 commits intolightningnetwork:masterfrom
ellemouton wants to merge 12 commits intolightningnetwork:masterfrom
Conversation
Contributor
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
ellemouton
changed the title
ellemouton
force-pushed
the
elle-namespacedMC
branch
from
8e4c0e5 to
5c444a6
Compare
ellemouton
force-pushed
the
rb-updateMC
branch
3 times, most recently
from
97fba78 to
b9d6a9c
Compare
ellemouton
force-pushed
the
elle-namespacedMC
branch
from
5c444a6 to
a996efe
Compare
ellemouton
force-pushed
the
rb-updateMC
branch
from
b9d6a9c to
95c232c
Compare
ellemouton
force-pushed
the
rb-updateMC
branch
from
95c232c to
9f07fdf
Compare
ellemouton
force-pushed
the
rb-updateMC
branch
from
9f07fdf to
dfa0b98
Compare
ellemouton
added
the
size/mega
ellemouton
force-pushed
the
elle-namespacedMC
branch
from
a996efe to
c2195f1
Compare
ellemouton
force-pushed
the
rb-updateMC
branch
from
dfa0b98 to
b6e1be7
Compare
This new struct holds the zpay32.BlindedPaymentPath along with other useful info about the constructed path like: 1) the session key: which we can later use (as the path constructor) to decrypt the blobs we sent to each blinded hop in the path. 2) the last ephemeral pub key which we can use to uniquely identify this path.
Move it to the models package to avoid import cycles later on.
instead of route.Route. This will be useful for a later commit when we only have access to MCRoute and want to report success to MC.
Note that then new field is not yet persisted.
in the new "blinded-paths" namespace.
Start querying blinded path probabilites from the new MC namespace where the results of successful blinded path receives will be written to.
ellemouton
force-pushed
the
rb-updateMC
branch
from
b6e1be7 to
c5f2e11
Compare
Collaborator
|
@ellemouton is this something we should target for 0.21? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, we start persisting invoice blinded path info. Then, when we receive a payment from a blinded path, we can use this info to report success to mission control. This will then ensure that future selected routes for blinded paths are of better quality.
Fixes #8991
(Addresses part 4 of #6690)
Depends on:
TODO: