Skip to content

sqldb: add blinded path tables#9003

Draft
ellemouton wants to merge 2 commits intolightningnetwork:masterfrom
ellemouton:sqldbBlindedPathTables
Draft

sqldb: add blinded path tables#9003
ellemouton wants to merge 2 commits intolightningnetwork:masterfrom
ellemouton:sqldbBlindedPathTables

Conversation

@ellemouton
Copy link
Copy Markdown
Collaborator

@ellemouton ellemouton commented Aug 14, 2024

This commit adds two new tables: blinded_paths and blinded_path_hops.
A single invoice can have multiple blinded_path entries and a single
blinded_path can have multiple blinded_paths.
The commit also adds various queries for the two new tables.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Aug 14, 2024 •
edited
Loading

Important

Review skipped

Auto reviews are limited to specific labels.

Labels to auto review (1)
  • llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ellemouton ellemouton mentioned this pull request Aug 14, 2024
Open
@ellemouton ellemouton force-pushed the sqldbBlindedPathTables branch 2 times, most recently from 81ee0dd to 51b74ae Compare August 15, 2024 07:37
ellemouton
ellemouton commented Aug 15, 2024
View reviewed changes
@ellemouton ellemouton added the size/kilo medium, proper context needed, less than 1000 lines label Aug 22, 2024
@ellemouton ellemouton force-pushed the sqldbBlindedPathTables branch from 51b74ae to 0661960 Compare September 9, 2024 08:38
@ellemouton
sqldb: add blinded path tables
98897bc 
This commit adds two new tables: blinded_paths and blinded_path_hops. A
single invoice can have multiple blinded_path entries and a single
blinded_path can have multiple blinded_paths.
The commit also adds various queries for the two new tables.
@ellemouton
docs: add release note
0ec3cf6
@ellemouton ellemouton force-pushed the sqldbBlindedPathTables branch from 0661960 to 0ec3cf6 Compare September 9, 2024 09:05
MPins
MPins reviewed Feb 4, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@MPins MPins left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the commit sqldb: add blinded path tables message if I’m not mistaken, when you wrote ... a single blinded_path can have multiple blinded_paths, you meant to say ... a single blinded_path can have multiple blinded_path_hops.

MPins
MPins reviewed Feb 4, 2025
View reviewed changes
sqldb/sqlc/migrations/000005_invoice_blinded_paths.up.sql
-- blinded_paths contains information about blinded paths included in the
-- associated invoice.
CREATE TABLE IF NOT EXISTS blinded_paths(
-- The id of the blinded path
Copy link
Copy Markdown
Contributor

@MPins MPins Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: missing the end point

sqldb/sqlc/migrations/000005_invoice_blinded_paths.up.sql
-- channel_id is the ID of the channel that connects this hop to the previous one.
channel_id BIGINT NOT NULL,

-- node_pub_key is the public key of the node of this hop
Copy link
Copy Markdown
Contributor

@MPins MPins Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: missing the end point

@saubyk saubyk added this to the v0.20.0 milestone Feb 6, 2025
@lightninglabs-deploy
Copy link
Copy Markdown
Collaborator

lightninglabs-deploy commented Feb 11, 2025

@ellemouton, remember to re-request review from reviewers when ready

@ellemouton ellemouton marked this pull request as draft February 11, 2025 14:35
@saubyk saubyk removed this from the v0.20.0 milestone Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MPins MPins MPins left review comments

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

@ellemouton ellemouton

Labels

size/kilo medium, proper context needed, less than 1000 lines

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ellemouton @lightninglabs-deploy @MPins @saubyk