Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding language option and updating swift App Delegate #201

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/liftoff/option_fetcher.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ def fetch_options
fetch_option_for(:company_identifier, 'Company identifier')
fetch_option_for(:prefix, 'Prefix')
fetch_option_for(:test_target_name, 'Test target name')
fetch_option_for(:project_template, 'Project language')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can already be passed on the command line. I don't think we also need it in the prompt.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not user-friendly to pass language param only in command-line, 'cause user can forgot to do this and project will be generated with default language

end

private
Expand Down
9 changes: 9 additions & 0 deletions templates/AppDelegate.swift
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
//
// AppDelegate.swift
// <%= project_name %>
//
// Created by <%= author %> on <%= Time.now.strftime("%-m/%-d/%y") %>
// Copyright (c) <%= Time.now.strftime('%Y') %> <%= company %>. All rights reserved.
//


import UIKit

@UIApplicationMain
Expand Down