-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding language option and updating swift App Delegate #201
Conversation
👎 for me on this. I'd like to avoid this comment at the top of the file baggage. |
import UIKit | ||
|
||
@UIApplicationMain | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually don't think this newline should be here since @UIApplicationMain
is a decorator on the class below it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 yep, this is my mistake 😢
@Keithbsmiley why u want to avoid comments on this file? I mean - in whole app u will be have author information, except this file, so why to avoid the author info only on this file?) |
I've also been removing those comments from the other files. |
by default with xcode author information will be generated with new file creation, so maybe keep it as by default? I think better to keep all files in one style |
Fair enough. Overall this is @gfontenot's decision. You can always add this as a local template if you want to override the default. |
I'd rather not update the default template with the header comments. I don't use them in any other files, and it's fairly trivial to locally override the default template with a version that includes header comments if that's what you want. |
@gfontenot k, will be deleted |
@@ -10,6 +10,7 @@ def fetch_options | |||
fetch_option_for(:company_identifier, 'Company identifier') | |||
fetch_option_for(:prefix, 'Prefix') | |||
fetch_option_for(:test_target_name, 'Test target name') | |||
fetch_option_for(:project_template, 'Project language') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can already be passed on the command line. I don't think we also need it in the prompt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is not user-friendly to pass language param only in command-line, 'cause user can forgot to do this and project will be generated with default language
OK, been contemplating this overnight. Here's what I'm thinking:
This does bring up an interesting idea for me of allowing users to customize their prompts. I have no idea how this would work, or if it's even feasible, but it's a thought. |
ping @thoughtbot/ios for thoughts on the prompt issue. |
I'm with @gfontenot on both points. |
👍 |
Closing in favor of #211 |
No description provided.