LPD-34947 Improve accessibility in calendar navigation #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-franca
commented
Sep 18, 2024
| background-color: #758FBB; | ||
| } | ||
| background-color: #DCDEF5 !important; | ||
| } |
There was a problem hiding this comment.
Hey @ethib137, the main objective of this change was to bring this style to the selected week. Because they did not undergo any style change when highlighted.
The style I overwrote was this:
I tried to do this in other more elegant ways, but to no avail, let me know if you have any advice on this.
ethib137
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #45
Now I was able to learn how to perform local tests at runtime of the changes made! I created a small documentation showing how to do this to avoid unnecessary releases.
Thank you for the reviews and release @ethib137 @bryceosterhaus.
I believe we are now on the right path! Tests performed at runtime with changes made to this PR:
simplescreenrecorder-2024-09-17_18.38.42.mp4