LPD-34947 Improve accessibility in calendar navigation #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethib137
approved these changes
Sep 11, 2024
|
A release of AlloyUI witht this change is published -> https://repository.liferay.com/nexus/content/repositories/liferay-public-releases/com/liferay/webjars/com.liferay.webjars.alloy-ui/3.1.0-deprecated.122/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #44
Still unable to perform all the necessary tests at run time. But I was able to perform some tests in the browser and noticed two things:
The .all() function does not return a list itself, but rather an object that contains _nodes which is in fact a list, therefore, I believe we could use e._nodes.length.
I performed other tests and realized that the setAttribute function can handle the object returned by .all(), see:
simplescreenrecorder-2024-09-11_10.11.41.mp4
So I decided to remove the iteration.
As we are unable to test the entire flow, later errors may still be found.