Skip to content

LPS-127831 Sets proper active class depending on search container displayStyle#837

Closed
jbalsas wants to merge 1 commit into
liferay-frontend:masterfrom
jbalsas:LPS-127831-Fix
Closed

LPS-127831 Sets proper active class depending on search container displayStyle#837
jbalsas wants to merge 1 commit into
liferay-frontend:masterfrom
jbalsas:LPS-127831-Fix

Conversation

@jbalsas

@jbalsas jbalsas commented Feb 25, 2021

Copy link
Copy Markdown

After dropping the BS3-BS4 compat layer, the active class no longer works for table displays which need the table-active class instead.

This commit makes it so the table-active class is used for tables (default displayStyle) and active for any other visualization.

This is a continuation of #821 because I couldn't push to @pat270's origin...

@pat270 @jbalsas
LPS-127831 Sets proper active class depending on search container dis…
4fc3527 
…playStyle

After dropping the BS3-BS4 compat layer, the `active` class no longer works
for table displays which need the `table-active` class instead.

This commit makes it so the `table-active` class is used for tables (default
displayStyle) and `active` for any other visualization.
@liferay-continuous-integration

liferay-continuous-integration commented Feb 25, 2021

Copy link
Copy Markdown
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

@jbalsas jbalsas mentioned this pull request Feb 25, 2021
Closed
@liferay-continuous-integration

liferay-continuous-integration commented Feb 25, 2021

Copy link
Copy Markdown
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 12 hours 18 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 232b7029dbcc5cc632db42fdd9f88161634e3e96

Sender Branch:

Branch Name: LPS-127831-Fix
Branch GIT ID: 4fc35270174434ba765132f8ca7f36346b5f4e44

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration

liferay-continuous-integration commented Feb 25, 2021

Copy link
Copy Markdown
Collaborator

Jenkins Build:test-portal-source-format#3816
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-frontend#837
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:sf
Spira Release Build:master - jbalsas > liferay-frontend - PR#837 - 2021-02-25[01:05:10]
Spira Jenkins Build:publish-spira-report#12252

@wincent

wincent commented Feb 25, 2021

Copy link
Copy Markdown

ci:test:bundle

@wincent

wincent commented Feb 25, 2021

Copy link
Copy Markdown

Code looks good to me, but I fired off a ci:test:bundle in case @marcoscv-work or @pat270 want to run and test this without having to pull it down and build it.

@liferay-continuous-integration

liferay-continuous-integration commented Feb 25, 2021

Copy link
Copy Markdown
Collaborator

✔️ ci:test:bundle - 1 out of 1 jobs passed in 45 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 232b7029dbcc5cc632db42fdd9f88161634e3e96

ci:test:bundle - 1 out of 1 jobs PASSED
For more details click here.
Test bundle downloads:

@liferay-continuous-integration

liferay-continuous-integration commented Feb 25, 2021

Copy link
Copy Markdown
Collaborator

✔️ ci:test:stable - 9 out of 9 jobs passed

❌ ci:test:relevant - 21 out of 23 jobs passed in 2 hours 30 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 232b7029dbcc5cc632db42fdd9f88161634e3e96

Upstream Comparison:

Branch GIT ID: 232b7029dbcc5cc632db42fdd9f88161634e3e96
Jenkins Build URL: Acceptance Upstream DXP (master) #1578

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 21 out of 23 jobs PASSED
21 Successful Jobs:
For more details click here.

Failures unique to this pull:

For upstream results, click here.

@jbalsas

jbalsas commented Feb 25, 2021

Copy link
Copy Markdown
Author

1 Test Failed.

youdidnt

@liferay-continuous-integration

liferay-continuous-integration commented Feb 25, 2021

Copy link
Copy Markdown
Collaborator

Jenkins Build:test-portal-acceptance-pullrequest(master)#5502
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-frontend#837
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:relevant
Spira Release Build:master - jbalsas > liferay-frontend - PR#837 - 2021-02-25[01:05:05]
Spira Jenkins Build:publish-spira-report#13643

@jbalsas jbalsas mentioned this pull request Feb 25, 2021
Closed
@jbalsas

jbalsas commented Feb 25, 2021

Copy link
Copy Markdown
Author

Manually forwarded to brianchandotcom#99234

@john-co, @calvinctvo, please double check but I don't think that test is related.

@jbalsas jbalsas closed this Feb 25, 2021
@john-co

john-co commented Feb 25, 2021

Copy link
Copy Markdown

[Unrelated]

  • LocalFile.CommerceSmoke#PublishSimpleProduct - Test looks flaky, failing on SelectFrame.selectFrameNoLoading(locator1 = "IFrame#MODAL_BODY"); I think test step needs to waitFor the Iframe to load, suggest replace with SelectFrame(locator1 = "IFrame#MODAL_BODY");

cc/ @iovaneale please investigate and fix/quarantine flaky test.

@jbalsas jbalsas deleted the LPS-127831-Fix branch September 14, 2021 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcoscv-work marcoscv-work Awaiting requested review from marcoscv-work
@pat270 pat270 Awaiting requested review from pat270

Assignees

@pat270 pat270

@marcoscv-work marcoscv-work

Labels

ci:test:relevant - failure ci:test:sf - success ci:test:stable - success

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jbalsas @liferay-continuous-integration @wincent @john-co @pat270 @marcoscv-work