LPS-127831 Sets proper active class depending on search container displayStyle#99234
Closed
jbalsas wants to merge 1 commit into
Closed
LPS-127831 Sets proper active class depending on search container displayStyle#99234jbalsas wants to merge 1 commit into
jbalsas wants to merge 1 commit into
Conversation
…playStyle After dropping the BS3-BS4 compat layer, the `active` class no longer works for table displays which need the `table-active` class instead. This commit makes it so the `table-active` class is used for tables (default displayStyle) and `active` for any other visualization.
Collaborator
|
Closing pull request because all |
Author
|
ci:reopen |
Owner
|
Merged. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual forward of liferay-frontend#837 to avoid re-running CI due to 1 failed unrelated test:
✔️ ci:test:stable - 9 out of 9 jobs passed
❌ ci:test:relevant - 21 out of 23 jobs passed in 2 hours 30 minutes
After dropping the BS3-BS4 compat layer, the
activeclass no longer works for table displays which need thetable-activeclass instead.This commit makes it so the
table-activeclass is used for tables (default displayStyle) andactivefor any other visualization.