Repository navigation
test(layout): compact layout.json back under the line ratchet - #6733
Conversation
…atchet #6721 and #6724 each added one explicit registration and together took scripts/test-layout/layout.json to 2000 lines, over the 1999-line NEW_OVERSIZED ratchet, so file-size ratchet: repository fails on dev and on every PR's merge ref. Fold forty single-entry lines into four-per-line rows (the file's existing compact form). The parsed mapping is unchanged; the file drops to 1970 lines.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe test layout manifest reformats existing Ollama, OMO/OMP, opaque-blob, and OpenAI test mappings. Test names and suite assignments are unchanged. ChangesTest layout manifest
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Other Merge Risk: ⚪ Minimal · up to The formatting change preserves the test mappings and brings the manifest below the enforced line threshold, with no identified merge-blocking risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
Summary
devis red onfile-size ratchet: repository: #6721 and #6724 each added one explicit registration toscripts/test-layout/layout.json, and together they took it to 2000 lines, one over the 1999-lineNEW_OVERSIZEDratchet. Each branch passed at its own head; the union does not, so every open PR's merge-ref CI now fails that test (seen on #6731, test 2/4).Fold forty single-entry lines (file lines 1300–1339) into four-per-line rows, the compact form the file already uses. The parsed mapping is byte-for-byte unchanged (asserted with
json.loadsequality); the file drops to 1970 lines, leaving headroom for the other open PRs that register tests. The folded range avoids the hunks of the open layout-touching PRs;git merge-treeagainst #6725, #6727, #6728, #6731 and #6732 is clean.Verification
bun test tests/ci-workflows/file-size-ratchet.test.ts tests/test-layout.test.ts tests/test-layout-tooling.test.ts --timeout 120000: 27 pass, 0 fail.wc -l: 2000 → 1970.tests/fixtures/test-layout-expected.jsonneeds no change (inventory unchanged).Checklist
Summary by CodeRabbit