Skip to content

test(layout): compact layout.json back under the line ratchet - #6733

Merged
lidge-jun merged 1 commit into
devfrom
codex/layout-ratchet-headroom
Oct 8, 2026
Merged

lidge-jun merged 1 commit into
devfrom
codex/layout-ratchet-headroom

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Oct 8, 2026 •

Copy link
Copy Markdown
Owner

Summary

dev is red on file-size ratchet: repository: #6721 and #6724 each added one explicit registration to scripts/test-layout/layout.json, and together they took it to 2000 lines, one over the 1999-line NEW_OVERSIZED ratchet. Each branch passed at its own head; the union does not, so every open PR's merge-ref CI now fails that test (seen on #6731, test 2/4).

Fold forty single-entry lines (file lines 1300–1339) into four-per-line rows, the compact form the file already uses. The parsed mapping is byte-for-byte unchanged (asserted with json.loads equality); the file drops to 1970 lines, leaving headroom for the other open PRs that register tests. The folded range avoids the hunks of the open layout-touching PRs; git merge-tree against #6725, #6727, #6728, #6731 and #6732 is clean.

Verification

  • bun test tests/ci-workflows/file-size-ratchet.test.ts tests/test-layout.test.ts tests/test-layout-tooling.test.ts --timeout 120000: 27 pass, 0 fail.
  • Parsed JSON equality before/after; wc -l: 2000 → 1970.
  • tests/fixtures/test-layout-expected.json needs no change (inventory unchanged).

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

Summary by CodeRabbit

  • Chores
    • Reformatted the test layout manifest; test-to-suite mappings remain unchanged.

…atchet

#6721 and #6724 each added one explicit registration and together took scripts/test-layout/layout.json to 2000 lines, over the 1999-line NEW_OVERSIZED ratchet, so file-size ratchet: repository fails on dev and on every PR's merge ref. Fold forty single-entry lines into four-per-line rows (the file's existing compact form). The parsed mapping is unchanged; the file drops to 1970 lines.
@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner October 8, 2026 02:00
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T02:01:22.223794Z 9fa63a8 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: lidge-jun/opencodex/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 816bb8d1-e22d-4947-8d71-ffdeeab8ab06
📥 Commits

Reviewing files that changed from the base of the PR and between 1a8377d and 9fa63a8.

📒 Files selected for processing (1)
  • scripts/test-layout/layout.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The test layout manifest reformats existing Ollama, OMO/OMP, opaque-blob, and OpenAI test mappings. Test names and suite assignments are unchanged.

Changes

Test layout manifest

Layer / File(s) Summary
Reformat test mappings
scripts/test-layout/layout.json
Lines 1300–1309 group existing test mappings across lines. Test names and suite assignments do not change.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 9fa63

The formatting change preserves the test mappings and brings the manifest below the enforced line threshold, with no identified merge-blocking risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: compacting layout.json to reduce its line count below the configured line ratchet. It matches the stated objective and file changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature). label Oct 8, 2026
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@lidge-jun
lidge-jun merged commit 56f76fd into dev Oct 8, 2026
33 of 34 checks passed
@lidge-jun
lidge-jun deleted the codex/layout-ratchet-headroom branch October 8, 2026 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant