Repository navigation
feat(cli): expose ocx resolve and ocx stop --json for embedding shells #5383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
bcefd8a
feat(cli): expose ocx resolve and ocx stop --json for embedding shells
lidge-jun 73b7b1a
test(cli): pin the resolve and stop-summary contracts
lidge-jun c974152
docs: document the resolve and stop --json shell contracts
lidge-jun 8cc464b
test(grok): follow handleStop structured return in the lifecycle oracle
lidge-jun ec69310
test(cli): satisfy the structured handleStop type in the effort fake
lidge-jun 30cfe68
fix(cli): tighten the resolve/stop contract after review
lidge-jun f3a8d1b
test(cli): pin the refused-guess, ownership-budget, and failed-teardo…
lidge-jun 5b19417
docs: state the invalid-config refusal and the ownership probe budget
lidge-jun edc3814
test(cli): restore process.exitCode with the suite convention
lidge-jun 6fcd0ee
test(cli): assert the stream split with emitting stubs
lidge-jun f801243
fix(cli): tri-state resolve liveness and read-only resolve entry
lidge-jun c3b46dd
test(cli): match the endpoint-proof short-circuit
lidge-jun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After
handleStopwas changed from returning a boolean to returningStopOutcome, the awaited value here is always a truthy object. Thus a failed stop—including ownership refusal, an unresolvable PID, or a respawned proxy—still prints that requests will fail until the proxy is restarted, even though the proxy may remain live. Check(await deps.handleStop()).ok, as the JSON branch already does.Useful? React with 👍 / 👎.