-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update ipfs-http-client peer dep #41
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4148608
chore: update ipfs-http-client peer dep
achingbrain 76a0794
chore: update deps
achingbrain 2ee721b
chore: linting
achingbrain be0e220
chore: guard on peer not being defined
achingbrain c0523f1
chore: wait for peers to connect
achingbrain 8c62317
chore: try ipfsd-ctl branch
achingbrain 04825f4
chore: fix typo
achingbrain e9a709f
chore: revert ipfsd branch
achingbrain File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,20 +14,16 @@ const factory = createFactory({ | |
ipfsHttpModule: require('ipfs-http-client'), | ||
ipfsBin: isNode ? require('go-ipfs').path() : undefined, | ||
test: true, | ||
disposable: true, | ||
endpoint: 'http://localhost:57483' | ||
}) | ||
|
||
async function spawnNode (boostrap = []) { | ||
async function spawnNode (bootstrap = []) { | ||
const node = await factory.spawn({ | ||
// Lock down the nodes so testing can be deterministic | ||
ipfsOptions: { | ||
config: { | ||
Bootstrap: boostrap, | ||
Discovery: { | ||
MDNS: { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. MDNS is disabled already when ipfsd is passed the |
||
Enabled: false | ||
} | ||
} | ||
Bootstrap: bootstrap | ||
} | ||
} | ||
}) | ||
|
@@ -107,7 +103,10 @@ describe('DelegatedPeerRouting', function () { | |
host: opts.host | ||
})) | ||
|
||
const { id, multiaddrs } = await router.findPeer(peerIdToFind.id) | ||
const peer = await router.findPeer(peerIdToFind.id) | ||
expect(peer).to.be.ok() | ||
|
||
const { id, multiaddrs } = peer | ||
expect(id).to.exist() | ||
expect(multiaddrs).to.exist() | ||
expect(id).to.eql(peerIdToFind.id) | ||
|
@@ -121,7 +120,10 @@ describe('DelegatedPeerRouting', function () { | |
host: opts.host | ||
})) | ||
|
||
const { id, multiaddrs } = await router.findPeer(PeerID.createFromB58String(peerIdToFind.id)) | ||
const peer = await router.findPeer(PeerID.createFromB58String(peerIdToFind.id)) | ||
expect(peer).to.be.ok() | ||
|
||
const { id, multiaddrs } = peer | ||
expect(id).to.exist() | ||
expect(multiaddrs).to.exist() | ||
|
||
|
@@ -136,7 +138,10 @@ describe('DelegatedPeerRouting', function () { | |
host: opts.host | ||
})) | ||
|
||
const { id, multiaddrs } = await router.findPeer(PeerID.createFromB58String(peerIdToFind.id), { timeout: 2000 }) | ||
const peer = await router.findPeer(PeerID.createFromB58String(peerIdToFind.id), { timeout: 2000 }) | ||
expect(peer).to.be.ok() | ||
|
||
const { id, multiaddrs } = peer | ||
expect(id).to.exist() | ||
expect(multiaddrs).to.exist() | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should really clean up after ourselves