chore: update ipfs-http-client peer dep #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes this sort of error: ``` npm ERR! Conflicting peer dependency: [email protected] npm ERR! node_modules/ipfs-http-client npm ERR! peer ipfs-http-client@"^46.0.0" from [email protected] npm ERR! node_modules/libp2p-delegated-content-routing npm ERR! libp2p-delegated-content-routing@"^0.7.0" from the root project ```
jacobheun
reviewed
Oct 21, 2020
|
Ah, looks like CI has node 15 now, likely causing the failures. |
|
What fun: ai/nanoid#239 What's happening here is |
|
Should be fixed in node 15.0.1 - nodejs/node@f7abd6a |
achingbrain
commented
Oct 21, 2020
| const node = await factory.spawn({ | ||
| // Lock down the nodes so testing can be deterministic | ||
| ipfsOptions: { | ||
| config: { | ||
| Bootstrap: boostrap, | ||
| Discovery: { | ||
| MDNS: { |
There was a problem hiding this comment.
MDNS is disabled already when ipfsd is passed the test: true config option
achingbrain
commented
Oct 21, 2020
| @@ -14,20 +14,16 @@ const factory = createFactory({ | |||
| ipfsHttpModule: require('ipfs-http-client'), | |||
| ipfsBin: isNode ? require('go-ipfs').path() : undefined, | |||
| test: true, | |||
| disposable: true, | |||
There was a problem hiding this comment.
Should really clean up after ourselves
jacobheun
approved these changes
Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this sort of error: