Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suppressing error msg for NoSecurity option #498

Merged
merged 5 commits into from
Dec 3, 2018
Merged

suppressing error msg for NoSecurity option #498

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a5dc4a9
Merge pull request #3 from libp2p/master
upperwal Jul 30, 2018
962dc05
Merge pull request #4 from libp2p/master
upperwal Nov 30, 2018
88d9828
suppressing error msg for NoSecurity option
upperwal Nov 30, 2018
3ae2d75
added comments for clarity
upperwal Dec 1, 2018
36a2645
removing redundant if condition
upperwal Dec 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion p2p/protocol/identify/id.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,9 +186,18 @@ func (ids *IDService) populateMessage(mes *pb.Identify, c inet.Conn) {

// set our public key
ownKey := ids.Host.Peerstore().PubKey(ids.Host.ID())

// check if we even have a public key.
if ownKey == nil {
log.Errorf("did not have own public key in Peerstore")
// public key is nil. We are either using insecure transport or something erratic happened.
// check if we're even operating in "secure mode"
if ids.Host.Peerstore().PrivKey(ids.Host.ID()) != nil {
// private key is present. But NO public key. Something bad happened.
log.Errorf("did not have own public key in Peerstore")
}
// if neither of the key is present it is safe to assume that we are using an insecure transport.
} else {
// public key is present. Safe to proceed.
if kb, err := ownKey.Bytes(); err != nil {
log.Errorf("failed to convert key to bytes")
} else {
Expand Down