suppressing error msg for NoSecurity option #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Getting updates
pulling updates
|
Resolves #493 |
Stebalien
requested changes
Nov 30, 2018
p2p/protocol/identify/id.go
Outdated
| @@ -186,9 +186,11 @@ func (ids *IDService) populateMessage(mes *pb.Identify, c inet.Conn) { | |||
|
|
|||
| // set our public key | |||
| ownKey := ids.Host.Peerstore().PubKey(ids.Host.ID()) | |||
| if ownKey == nil { | |||
| prKey := ids.Host.Peerstore().PrivKey(ids.Host.ID()) | |||
There was a problem hiding this comment.
Let's make it clear why we're checking for the private key. Something like:
if ownKey == nil {
// check if we're even operating in "secure mode"
if ids.Host.Peerstore().PrivKey(ids.Host.ID()) != nil {
// warn
}
} else ...(this also avoid storing the private key to make it clear that we're just checking to see if we have it)
Stebalien
approved these changes
Dec 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
identitydisplays an error iflibp2p.NoSecurityoption is used. This change will suppress it by also checking for private key.