Slokesha/update qwen from v0.14.1#5
Merged
slokesha merged 8 commits intoFeb 9, 2026
Merged
Conversation
for qwen3 vl, there is accuracy issue with multi-images within 1 request, this PR is to fix that. After fix, there are 3 paths for vision attention depending on the images count inside 1 request 1. single image, use fusedsdpa without attn mask 3. multi-images with threshold use fusedsdpa without attn_mask one by one This pr also enables qwen3vl moe --------- Signed-off-by: slokesha <slokeshappa@habana.ai> Signed-off-by: Jakub Byczkowski <jbyczkowski@habana.ai> Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai> Signed-off-by: Radoslaw Smyrek <radoslawx.smyrek@intel.com> Signed-off-by: linoy buchnik <lbuchnik@habana.ai> Signed-off-by: Iryna Boiko <iboiko@habana.ai> Signed-off-by: Artur Fierka <artur.fierka@intel.com> Signed-off-by: Luca Calabria <luca.calabria@intel.com> Co-authored-by: Seunghyuk Park <separk@habana.ai> Co-authored-by: Jakub Byczkowski <jbyczkowski@habana.ai> Co-authored-by: Agata Dobrzyniewicz <160237065+adobrzyn@users.noreply.github.com> Co-authored-by: Chendi.Xue <chendi.xue@intel.com> Co-authored-by: Radosław Smyrek <radoslawx.smyrek@intel.com> Co-authored-by: Linoy Buchnik <linoybu@gmail.com> Co-authored-by: Iryna Boiko <iboiko@habana.ai> Co-authored-by: Artur Fierka <artur.fierka@intel.com> Co-authored-by: Luca Calabria <luca.calabria@intel.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: slokesha <slokeshappa@habana.ai> Co-authored-by: Seunghyuk Park (shepark) <seunghyuk.h.park@intel.com> Co-authored-by: Michał Kuligowski <michal.kuligowski@intel.com> Co-authored-by: Katarzyna Fojcik <kfojcik@habana.ai> Co-authored-by: Krzysztof Smusz <ksmusz@habana.ai> Co-authored-by: Jozef Mamza <jmamzax@habana.ai>
Signed-off-by: slokesha <spurthi.lokeshappa@intel.com>
* Prevent cu_seqlens/mask mix-ups that can trigger performance regressions or incorrect attention behavior. * Remove the lens = (cu_seqlens[1:] - cu_seqlens[:-1]).tolist() computation from the Qwen2.5 path. This calculation is not required for Qwen2.5 and was causing a performance regression after PR vllm-project#884. Removing it restores the previous performance without changing model behavior.
Signed-off-by: slokesha <spurthi.lokeshappa@intel.com>
slokesha
added a commit
that referenced
this pull request
Feb 9, 2026
* Qwen3vl accuracy fixes (vllm-project#884) for qwen3 vl, there is accuracy issue with multi-images within 1 request, this PR is to fix that. After fix, there are 3 paths for vision attention depending on the images count inside 1 request 1. single image, use fusedsdpa without attn mask 3. multi-images with threshold use fusedsdpa without attn_mask one by one This pr also enables qwen3vl moe Signed-off-by: slokesha <slokeshappa@habana.ai>
slokesha
added a commit
that referenced
this pull request
Feb 9, 2026
* Qwen3vl accuracy fixes (vllm-project#884) for qwen3 vl, there is accuracy issue with multi-images within 1 request, this PR is to fix that. After fix, there are 3 paths for vision attention depending on the images count inside 1 request 1. single image, use fusedsdpa without attn mask 3. multi-images with threshold use fusedsdpa without attn_mask one by one This pr also enables qwen3vl moe Signed-off-by: slokesha <slokeshappa@habana.ai>
slokesha
added a commit
that referenced
this pull request
Feb 9, 2026
* Qwen3vl accuracy fixes (vllm-project#884) for qwen3 vl, there is accuracy issue with multi-images within 1 request, this PR is to fix that. After fix, there are 3 paths for vision attention depending on the images count inside 1 request 1. single image, use fusedsdpa without attn mask 3. multi-images with threshold use fusedsdpa without attn_mask one by one This pr also enables qwen3vl moe Signed-off-by: slokesha <slokeshappa@habana.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.