Update qwen2_5_vl attention forward#908
Merged
mgawarkiewicz-intel merged 1 commit intoFeb 2, 2026
Merged
Conversation
shepark
requested review from
mgawarkiewicz-intel,
piotrbocian and
wpyszka
as code owners
✅ CI PassedAll checks passed successfully against the following vllm commit: |
afierka-intel
approved these changes
Feb 2, 2026
mgawarkiewicz-intel
approved these changes
Feb 2, 2026
mgawarkiewicz-intel
merged commit f4a4797
into
vllm-project:releases/v0.14.1
53 checks passed
slokesha
pushed a commit
to slokesha/vllm-gaudi
that referenced
this pull request
Feb 2, 2026
* Prevent cu_seqlens/mask mix-ups that can trigger performance regressions or incorrect attention behavior. * Remove the lens = (cu_seqlens[1:] - cu_seqlens[:-1]).tolist() computation from the Qwen2.5 path. This calculation is not required for Qwen2.5 and was causing a performance regression after PR vllm-project#884. Removing it restores the previous performance without changing model behavior.
Collaborator
|
Is this needed on main? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This calculation is not required for Qwen2.5 and was causing a performance regression after PR #884. Removing it restores the previous performance without changing model behavior.