Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't put the private key in the error message #674

Merged
merged 1 commit into from
Oct 27, 2018

Conversation

tiennou
Copy link
Contributor

@tiennou tiennou commented Oct 27, 2018

Right now we're formatting the SSH private key as part of an NSError's description. This is pretty bad, because it might have been logged to the Console.

@tiennou tiennou merged commit 9c6558b into libgit2:master Oct 27, 2018
@tiennou tiennou deleted the fix/libssh2-memory-keys branch October 27, 2018 12:54
@tiennou tiennou mentioned this pull request Oct 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant